zach-overflow commented on PR #71346: URL: https://github.com/apache/airflow/pull/71346#issuecomment-5287364880
> What do we do with the argument collision? As this stands, the queue cannot actually be set by the user, can it? @uranusjr Fair point, I think I was a bit overzealous when I saw that the `MessageQueueTrigger` already had the `queue` parameter marked as deprecated. After some adjustments, I think I found a decent middle ground until whenever that deprecated parameter is fully removed: For the `MessageQueueTrigger` the `queue` parameter's meaning remains the same as before, while it's set to a private instance attribute instead (`_queue`) so we there's no collision with the BaseTrigger's `queue`. Users can then assign specifically the `MessageQueueTrigger` class to a "trigger queue" with the `trigger_queue` parameter. A little ugly, but I'm ok with it. I'm also ok with fully replacing the meaning of the `queue` value in that class so everything is consistent. No strong feelings either way on my end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
