hkc-8010 opened a new pull request, #71612:
URL: https://github.com/apache/airflow/pull/71612

   ## Summary
   
   Logs.test.tsx grew to 827 lines (539 counted, non-blank/non-comment) after 
#71270 added
   copy/text-selection tests, which trips the `max-lines` ESLint rule (cap 500,
   airflow-core/src/airflow/ui/rules/core.js:282). This was failing the 
scheduled ARM CI's
   `Static checks` job on main (run: 
https://github.com/apache/airflow/actions/runs/31782003145).
   
   ## Changes
   
   Move the copy/selection describes and their helper functions out of 
`Logs.test.tsx` into a
   new `LogsSelection.test.tsx`, in the same directory. No test logic changed, 
no tests removed
   (14 + 9 = 23 tests, same as before the split).
   
   - `airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx`
   - 
`airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/LogsSelection.test.tsx`
 (new)
   
   ## Note on the other CI failure in that run
   
   The same run also had `Non-DB tests: providers / Non-DB-prov::3.14` fail 
with "The hosted
   runner lost communication with the server" — a runner infra flake, not a 
code issue. Not
   addressed here.
   
   ## PR Checklist
   
   - [x] My PR is targeted at the `main` branch
   - [x] `prek` hooks pass (`ts-compile-lint-ui`, `eslint`, `prettier`)
   - [x] `pnpm vitest run` passes for both files (22/23 — the 1 failure is a 
pre-existing
         MSW/localhost:3000 mock flake, unrelated to this change and 
reproducible on the
         unmodified original file)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to