ephraimbuddy opened a new pull request, #71628:
URL: https://github.com/apache/airflow/pull/71628
Writing a Dag with a deadline rewrites its serialized deadline entries from
definitions into UUID references, and it did so on the object the caller passed
in. When update_dag_parsing_results_in_db hit a transient database error it
rolled back and retried the same objects, which by then held UUID strings where
definitions were expected. The retry raised AttributeError while re-encoding
them, and since that is not a database error it escaped the retry entirely, so
the manager discarded the whole file's parse results rather than one Dag's.
Rewrite a copy instead. Only the "dag" sub-dict is copied, so the bulk of
the serialized structure is still shared, and the Dag the caller holds stays in
the shape it arrived in however many times the write is attempted.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 5 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
