ferruzzi commented on issue #71577: URL: https://github.com/apache/airflow/issues/71577#issuecomment-5295785669
@shivaam Smaller PRs is 100% the right call, I just wanted to get the big picture down "on paper" while I was thinking about it. Your idea sounds reasonable, but benchmark it for sure, I have no idea what that translates to in runtime and memory. I don't think we want to be adding minutes to the CI runtime, but if it's milliseconds, then yeah, that sounds reasonable. It might also make sense for the enforcer and the detector to share an allowlist as well, which I didn't really consider yesterday. If we just create the detector right now, it's going to go off on all the existing issues. Flip side, if we do it first and the detector has an optional false-by-default flag which outputs its findings to the logs, then that acts as a triage for the tests to fix: "Here are all the tests right now that violate the policy" would help us split the actual issues from the tests that defensively pre-cleaned. So I guess there are arguments for either order. The detector does sound more fun though, so i don't blame you for taking that one first. :p -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
