bujjibabukatta commented on PR #71480: URL: https://github.com/apache/airflow/pull/71480#issuecomment-5303435295
> Please refer to the original issue for discussions. Thank you for the pointer. I've reviewed the original issue #71187 and implemented the fix with the correct scope. Key clarification: The issue title specifically mentions "when create_cron_data_intervals is enabled" — this flag controls which timetable class is instantiated: When enabled: CronDataIntervalTimetable / DeltaDataIntervalTimetable When disabled (default): CronTriggerTimetable / DeltaTriggerTimetable The initial implementation placed generate_run_id in the shared _DataIntervalTimetable base class, which incorrectly applied the logical_date anchoring to both cron and delta timetables. Updated implementation (latest commit): Moved generate_run_id override only to CronDataIntervalTimetable — this correctly limits the behavior to cron expressions when the flag is enabled> - DeltaDataIntervalTimetable (used for @daily, @hourly, timedelta()) now correctly retains AIP-76 run_after anchoring> - Added test test_generate_run_id_uses_run_after_for_delta_and_default_cron to verify this> - CronTriggerTimetable (AIP-76 default) remains unaffected as verified by test_generate_run_id_default_timetable_unaffected This aligns with the factory logic in _create_timetable (airflow/sdk/definitions/dag.py) where the config flag only controls cron vs trigger timetable selection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
