fat-catTW opened a new pull request, #71697:
URL: https://github.com/apache/airflow/pull/71697
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Why
Pausing a Dag currently blocks more than new Dag run creation. If a Dag is
paused while a Dag run is already `running`, the scheduler stops examining that
run and stops queueing its remaining scheduled task instances.
That leaves the run silently stuck in `running`, with remaining tasks
staying in `scheduled` and never reaching the executor. Unpausing fixes the
stuck run, but also allows new runs to start, which is not always what the
operator intended.
relates: #71381
## Solution
Keep pause behavior for new work, but let already-running Dag runs continue.
Queued Dag runs still require an unpaused Dag before they can move to
`running`. The scheduler now only removes the pause gate from paths that
operate on Dag runs already in `running` state:
- selecting running Dag runs for scheduler examination
- queueing scheduled task instances that belong to running Dag runs
This preserves pause as "do not start new runs" while allowing in-flight
runs to finish.
## Testing
- `uv run ruff check --fix airflow-core/src/airflow/models/dagrun.py
airflow-core/src/airflow/jobs/scheduler_job_runner.py
airflow-core/tests/unit/models/test_dagrun.py
airflow-core/tests/unit/jobs/test_scheduler_job.py`
- `uv run --project airflow-core pytest
airflow-core/tests/unit/models/test_dagrun.py::TestDagRun::test_next_dagruns_to_examine_paused_dag
airflow-core/tests/unit/jobs/test_scheduler_job.py::TestSchedulerJob::test_execute_task_instances_for_paused_running_dagrun
-q`
- `git diff --check`
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- `[X]` Yes (please specify the tool below)
Generated-by: [Codex] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
