potiuk commented on PR #70250: URL: https://github.com/apache/airflow/pull/70250#issuecomment-5316578431
Thanks — and sorry to close it. This overlaps #70249, opened the same day, which fixes the same `_python_type_from_string` type map. #70249 is the broader fix: it repairs both `datetime.date` and `datetime.datetime` (this PR covers only `datetime.datetime`, leaving date-typed parameters still broken), normalises the trailing `Z` the API actually emits, passes already-typed values through unchanged, and adds an end-to-end test that the generated `dagrun list --start-date` argument parses. Going with #70249 so both halves land together rather than in two passes. It has changes requested outstanding, so it isn't finished either — but the shape is the one to build on. Closing in its favour. The diagnosis was correct, and the `argparse.ArgumentTypeError` approach matches what #70249 landed on. --- _Drafted by an AI assistant and may contain mistakes — if you think this call is wrong, say so and the PR will be reopened; a human maintainer has the final word._ Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
