FrankYang0529 commented on code in PR #70065:
URL: https://github.com/apache/airflow/pull/70065#discussion_r3796861675
##########
airflow-core/tests/unit/jobs/test_scheduler_job.py:
##########
@@ -4275,6 +4278,35 @@ def
test_dagrun_timeout_duration_metric_has_run_type(self, mock_get_backend, dag
session.rollback()
session.close()
+ @mock.patch.object(DagRun, "produce_dag_callback", autospec=True)
+ def test_dagrun_timeout_without_on_failure_callback_produces_no_callback(
+ self, mock_produce_dag_callback, dag_maker
+ ):
+ """A timed-out run of a dag without on_failure_callback must not build
a callback request."""
Review Comment:
Updated it. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
