antruigon commented on code in PR #71237:
URL: https://github.com/apache/airflow/pull/71237#discussion_r3803277393


##########
chart/values.schema.json:
##########
@@ -7801,6 +7801,12 @@
                         }
                     ]
                 },
+                "terminationGracePeriodSeconds": {
+                    "description": "Grace period for PgBouncer to finish after 
SIGTERM is sent from Kubernetes. The default matches the default preStop hook, 
which needs up to 120 seconds to drain client connections.",

Review Comment:
   Applied. The rationale for the 120 default now lives as a comment in 
`values.yaml`



##########
chart/values.schema.json:
##########
@@ -7801,6 +7801,12 @@
                         }
                     ]
                 },
+                "terminationGracePeriodSeconds": {
+                    "description": "Grace period for PgBouncer to finish after 
SIGTERM is sent from Kubernetes. The default matches the default preStop hook, 
which needs up to 120 seconds to drain client connections.",
+                    "type": "integer",
+                    "default": 120,

Review Comment:
   Applied, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to