arose26 commented on PR #71710: URL: https://github.com/apache/airflow/pull/71710#issuecomment-5331251580
Thanks for the review — screenshots below. Both show the trigger form's Run Parameters section for a DAG param declared as type: ["object", "null"] that has not been given a value. Only the one line in FieldObject.tsx differs between them. Before — the editor opens on [], an array literal, for a param whose declared type is object: <img width="1520" height="748" alt="image" src="https://github.com/user-attachments/assets/a8f59ce9-1005-4f44-a72a-c63075d7b3c1"; /> After — it opens on {}, matching the declared type: <img width="1520" height="748" alt="image" src="https://github.com/user-attachments/assets/8d149640-0f45-4f94-8df0-9b72b67f51b2"; /> The rest of the field is unchanged: same label, same description, same editor. For transparency about how these were produced: rather than stand up a full Airflow instance, I rendered the real FlexibleForm in a local Vite page, mounted the same way ConfigForm mounts it in the trigger dialog (same Accordion.Root props, no noAccordion), seeded with a single object param. So the accordion section, the Row layout and the Monaco editor are the actual components with the actual styling — nothing mocked or redrawn. What is not pictured is the surrounding dialog chrome, since that comes from the modal rather than from this field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
