fat-catTW commented on code in PR #71729:
URL: https://github.com/apache/airflow/pull/71729#discussion_r3813077146


##########
airflow-core/newsfragments/71729.improvement.rst:
##########
@@ -0,0 +1 @@
+Add ``--limit`` option to ``airflow dags list-runs`` to cap output to the N 
most recent DAG runs after filters and sorting are applied, mirroring ``airflow 
dags list-jobs --limit``.

Review Comment:
   Same as above.
   ```suggestion
   Add ``--limit`` option to ``airflow dags list-runs`` to cap output to the N 
most recent Dag runs after filters and sorting are applied, mirroring ``airflow 
dags list-jobs --limit``.
   ```



##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -291,6 +291,11 @@ def string_lower_type(val):
     metavar=", ".join(dagrun_states),
     choices=dagrun_states,
 )
+ARG_DR_LIMIT = Arg(
+    ("--limit",),
+    type=positive_int(allow_zero=False),
+    help="Return a limited number of DAG runs, ordered by most recent 
run_after first",

Review Comment:
   Thanks for adding the newsfragment!
   
   One tiny style nit.
   In prose we use `Dag` rather than `DAG`, so could you change `DAG runs` to 
`Dag runs` in the CLI help text and newsfragment?
   ```suggestion
       help="Return a limited number of Dag runs, ordered by most recent 
run_after first",
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to