Tegh25 commented on code in PR #68359: URL: https://github.com/apache/airflow/pull/68359#discussion_r3815186041
########## airflow-core/src/airflow/listeners/spec/dag.py: ########## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING + +from pluggy import HookspecMarker + +if TYPE_CHECKING: + from airflow.timetables.base import SkippedIntervalsSummary + +hookspec = HookspecMarker("airflow") + + +@hookspec +def on_intervals_skipped(dag_id: str, summary: SkippedIntervalsSummary): Review Comment: From what I've observed, listener names are expressed in terms of the event being emitted. Here the event is specifically “intervals skipped” when `catchup=False`, and the fact that it’s Dag-scoped is already implied by it living in `listeners/spec/dag.py` and by the scheduler code calling `hook.on_intervals_skipped`. I'm happy to change the name if you feel strongly about it. However, given the maturity of this PR with the implementation, tests, docs, newsfragment, etc., it may be more effort than its worth to change the hook name for a small improvement. The original issue also mentioned adding a listener hook with the specific name of `on_intervals_skipped`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
