amoghrajesh commented on code in PR #71403: URL: https://github.com/apache/airflow/pull/71403#discussion_r3820201755
########## providers/common/ai/src/airflow/providers/common/ai/utils/usage.py: ########## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Helpers for merging the ``max_cost`` convenience parameter into ``UsageLimits``.""" + +from __future__ import annotations + +import dataclasses +from decimal import Decimal, InvalidOperation + +from pydantic_ai.usage import UsageLimits + + +def resolve_usage_limits( + usage_limits: UsageLimits | None, max_cost: Decimal | float | str | None Review Comment: Why dont we consider widening `usage_limits` itself to accept `UsageLimits | dict | None`, add `usage_limits` to `template_fields` (our jinja helpers renders every value inside the dict automatically, no custom code needed for that part), then in `execute()` you can coerce the rendered dict into a real `UsageLimits(**rendered)`, reusing the same defensive per field parsing that this PR already wrote for `cost_limit` specifically, applied to whichever fields the dict contains. This is genuinely the pattern KPO and similar operators already use (accept a templatable dict/spec, build the real object at execute time). It fixes the actual gap ("no UsageLimits field can be templated") once, for every knob like `request_limit`, `tool_calls_limit`, `total_tokens_limit`, `cost_limit` instead of adding a one off scalar parameter (`max_cost`) that only covers cost. If someone next needs a templated `request_limit`, this PR's pattern means writing another `max_requests` parameter but the dict approach needs nothing new. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
