fat-catTW commented on PR #71546: URL: https://github.com/apache/airflow/pull/71546#issuecomment-5359722269
Good point. I agree that a `StartedOn` cutoff could be a stronger semantic boundary, but I’m hesitant to use the Dag run `logical_date` for that because it is not the actual execution time, especially for manual runs and backfills. Using an actual Dag run or task start time may be a good follow-up, but I’d prefer to keep this PR focused on replacing the unbounded scan with a fixed worst-case bound. BTW. The page size was bumped to 200 after an earlier review comment, so the current hard cap is 2,000 runs rather than 500. Also, there is already a regression test for a match beyond the first page: `test_task_uuid_scan_paginates_until_match`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
