o-nikolas opened a new pull request, #71919:
URL: https://github.com/apache/airflow/pull/71919

   A plugin's team_name has so far only affected what the API returns about the 
plugin, not what its own endpoints allow. Because Airflow mounts plugin FastAPI 
apps on the shared API server and applies no authorization to them, a 
team-scoped plugin's endpoints were reachable by every authenticated user — so 
team_name.
   
   When multi-team mode is enabled, a team-scoped plugin's app is now mounted 
behind a middleware that rejects users who are not authorized for that team, 
using the auth manager's existing team check. Requests are authenticated the 
same way as the core API (bearer token or session cookie), and the request's 
HTTP method is mapped onto Airflow's resource methods so an auth manager can 
grant a team read-only access if it distinguishes them. Global plugins and 
deployments with multi-team disabled are unaffected.
   
   Root middlewares from a team-scoped plugin are skipped with a warning: they 
wrap every request to the API server, including other teams' and core routes, 
so they cannot be limited to one team. A team plugin that needs middleware 
should apply it inside its own app.
   
   ----
   ### UAT testing:
   
   #### Before the changes. A user could not list plugins but could still call 
them:
   Plugin `uat-team-a` does not show up in the list, but endpoints from that 
plugin **can** be called
   
   <img width="1452" height="170" alt="Screenshot from 2026-08-20 15-31-08" 
src="https://github.com/user-attachments/assets/0e183a42-9939-44ab-a01b-6911723aba18";
 />
   
   #### With this change they cannot list or call team plugins
   Plugin `uat-team-a` does not show up in the list and the endpoints from that 
plugin **cannot** be called
   <img width="1442" height="280" alt="Screenshot from 2026-08-20 15-37-26" 
src="https://github.com/user-attachments/assets/627e3280-71e0-4189-b8a8-c5583842eb4e";
 />
   
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to