uranusjr commented on code in PR #71882:
URL: https://github.com/apache/airflow/pull/71882#discussion_r3826341664
##########
go-sdk/pkg/execution/logger.go:
##########
@@ -134,6 +259,16 @@ func (h *SocketLogHandler) Handle(_ context.Context, r
slog.Record) error {
return true
})
+ loggerName, _ := entry["logger"].(string)
+ if !h.filter.isEnabled(loggerName, r.Level) {
+ return nil
+ }
+ levelName, ok := getAirflowLogLevelName(r.Level)
+ if !ok {
+ return nil
+ }
Review Comment:
Instead of silently dropping an invalid level name, should this try to
normalize to the closest level instead? IIRC I did some smart mapping with some
of the Java logging levels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
