yuseok89 opened a new pull request, #71922:
URL: https://github.com/apache/airflow/pull/71922
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
`HttpSensor(deferrable=True)` with a `response_check` silently fell back to
the synchronous poke loop, occupying a worker slot for the whole wait. It now
defers like any other deferrable sensor: the triggerer waits for the endpoint
to respond without error, the check runs on the worker, and if it returns False
the task defers again, keeping the `poke_interval` pacing.
The callable stays on the worker; only the response is carried back, reusing
the JSON serializer already in `triggers/http.py`. This is the same pattern
`S3KeySensor` uses for `check_fn`.
closes: 40209
### Verified with a live Dag
An `HttpSensor(deferrable=True, poke_interval=20)` polling this Airflow's
own api-server, with a `response_check` that only passes two minutes after the
run was triggered.
1. Before the change the task never left `running`, since a `response_check`
forced it onto the synchronous path.
2. After the change it sits in `deferred`, wakes every 20 seconds to
evaluate the check on the worker, logs that the check returned False and defers
again, then succeeds once the check passes.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Opus 4.8
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
