lubimow-xwf commented on PR #70681: URL: https://github.com/apache/airflow/pull/70681#issuecomment-5369372339
Hey @potiuk I addressed all of your comments. I've made significant changes to both `configuration.py` files. I believe I simplified the changes, now sorting does not change the existing implementation too much, it only extends it. I apologize I did it now but this wasn't my PR originally and it was approved before, so I thought it was a matter of a couple of minor fixes. Please take a look again and let me know what it looks like now, thanks Btw, just quickly regarding UI changes, right now this change adds a button to show a modal to show a single line of text. Was it discussed before where and what should it look like? If it was me, I would just add a note in the footer of the Variables table, without any additional clicks. But that's just my five cents, right now it's unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
