ephraimbuddy opened a new pull request, #71936:
URL: https://github.com/apache/airflow/pull/71936
Assets are shared across Dags and bundles by design, so the same rows are
reached by more than one writer -- two Dag processors, or one alongside
``airflow dags reserialize``. The order they were collected in was the order
the Dags happened to arrive, and that order is the order the rows are inserted
and so the order they are locked, which is all it takes for two writers to
deadlock on assets neither of them conflicts over.
Sorting after collecting rather than while, so a repeated asset is still
decided by the last definition of it rather than by where it sorts. Sorted
again after the existing rows are read back, since the query returns those in
whatever order it likes and activation locks them in the order it is handed.
This orders assets by identity. It does not order the other way
``asset_active`` can conflict, on a uri claimed under two names, which no
ordering can fix.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 5 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
