hunnguye commented on PR #71949: URL: https://github.com/apache/airflow/pull/71949#issuecomment-5371614709
I did notice PR #71939. However, by that point I had already finished the implementation on my side and only had testing left. I believe both approaches are very similar. My implementation additionally reuses the REST endpoint logic in operator/spark_submit.py to avoid duplicating the endpoint construction. One notable difference I noticed is that my implementation uses a POST request to kill the driver, following Spark's [REST API behavior](https://spark.apache.org/docs/latest/spark-standalone.html). PR #71939 appears to use DELETE. I'm not sure whether DELETE is also supported here, but POST is what I tested successfully against the Spark Standalone REST endpoint. Besides that there are some minor implementation differences. I’d be happy to compare the approaches and collaborate on a combined solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
