RehanAhmad25 commented on PR #70072: URL: https://github.com/apache/airflow/pull/70072#issuecomment-5378711412
@ephraimbuddy Following up here since it's been about a month with no activity, apologies for the gap on my end too, had to sync up with a bunch of upstream changes. Since that last comment, I rebased again to catch up with main (a good chunk had landed since, including some new migrations), fixed the resulting conflicts, and this time everything came through clean, no CI-blocking issues locally, no need to bypass any checks. While I was at it, I also caught and fixed a real bug that surfaced from the rebase: turned out `cached_get_dag()` has a fallback that returns a truthy base DAG even when the pinned version is unresolvable, so my original check was getting skipped. Moved it to run before that call instead, verified with the existing tests plus a full migration round-trip. Whenever you get a chance, would appreciate a look, and if it needs another round of workflow approval to get CI running, happy to poke that too. No rush, just wanted to bump this since it's been sitting a while. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
