Prab-27 commented on PR #68853:
URL: https://github.com/apache/airflow/pull/68853#issuecomment-5386402440
> Correct minimal fix for the `create-defaults` None→AttributeError crash —
mapping `None → {"operation": ..., "status": "success"}` in `convert_to_dict`
resolves it and prints cleanly.
>
> Before this goes in, please add a regression test — a +8/-0 bug fix with
no coverage will regress silently. Something like mocking `create_defaults` →
None and asserting the command doesn't crash and prints the success output
(mirroring the existing tests in `test_connections_command.py` /
`test_cli_config.py`).
>
> Minor: the `or obj is None` in `if not isinstance(obj, dict) or obj is
None:` is redundant — None already fails the `isinstance(dict)` check.
Yes ,one task has been done in other PR
will push next chnage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
