fat-catTW commented on code in PR #71654:
URL: https://github.com/apache/airflow/pull/71654#discussion_r3839180122
##########
airflow-core/tests/unit/api_fastapi/common/test_parameters.py:
##########
@@ -504,14 +504,11 @@ def test_end_date_returns_nullable_filter(self):
rf = _make_datetime_filter("end_date")
assert isinstance(rf, NullableDatetimeRangeFilter)
- def test_aliased_filter_name_returns_plain_filter(self):
- """dag_run_start_date uses attribute_name='start_date' via outer join;
NULL means 'no run',
- not 'currently running', so it must return a plain RangeFilter to
avoid inflating counts."""
+ def test_aliased_start_date_returns_nullable_filter(self):
rf = _make_datetime_filter("dag_run_start_date", model=DagRun,
attribute_name="start_date")
- assert type(rf) is RangeFilter
+ assert isinstance(rf, NullableDatetimeRangeFilter)
Review Comment:
Good catch. Thanks
This behavior change was not intentional. I restored the plain `RangeFilter`
for `dag_run_start_date`, so a Dag whose latest run is queued and has not
started remains excluded from this filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
