Lee-W commented on PR #72012:
URL: https://github.com/apache/airflow/pull/72012#issuecomment-5392449530

   > Thanks! Just noticed a minor thing here:
   > 
   > In 
[pydantic_ai.py:466](https://github.com/apache/airflow/blob/main/providers/common/ai/src/airflow/providers/common/ai/hooks/pydantic_ai.py#L466)
 -- The class docstring's example JSON (Connection fields section) still 
includes "vertexai": true here, but the prose right below it (lines 472-473 in 
this PR's diff) now says the field has no effect.
   > 
   > Since the `get_ui_field_behaviour()` placeholder a few lines down (line 
492) was already updated to drop `vertexai`, could this example be updated the 
same way so the two don't contradict each other?
   
   Good catch! Just updated it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to