bbovenzi commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3845007462
##########
airflow-core/src/airflow/ui/src/utils/links.ts:
##########
@@ -19,6 +19,18 @@
import type { TaskInstanceResponse } from "openapi/requests/types.gen";
import { taskInstanceRoutes } from "src/router";
+export type TaskInstanceTab =
Review Comment:
We have TaskInstanceTab tab declared here and in useUserSettings. But we
already have `tab.ts` from #70699.
Let's consolidate these sources of truth. Especially because the real source
of truth is the router.ts page. We probably want the constant and enum type to
live side-by-side and be used to power the router so that a future contributor
doesn't break these settings by adding another tab without knowing how many
other places they need to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
