Eason09053360 opened a new pull request, #72052:
URL: https://github.com/apache/airflow/pull/72052

   The chart's post-install `NOTES.txt` tells anyone still on the deprecated
   `flower.extraNetworkPolicies` to migrate to `flower.networkPolicy.peers`.
   That key does not exist. The parameter that actually replaced it is
   `flower.networkPolicy.ingress.from` — what the template reads, and what
   `values.yaml`, `values.schema.json` and `RELEASE_NOTES.rst` all document.
   
   It is not just a wrong name in a message. `flower.networkPolicy` is declared
   with `additionalProperties: false`, so following the warning fails the 
install
   outright:
   
   ```console
   $ helm template rn chart -f peers.yaml
   Error: values don't meet the specifications of the schema(s) in the 
following chart(s):
   airflow:
   - at '/flower/networkPolicy': additional properties 'peers' not allowed
   ```
   
   while the corrected key renders as intended:
   
   ```console
   $ helm template rn chart -f ingress-from.yaml \
       --show-only templates/flower/flower-networkpolicy.yaml
   ...
     ingress:
       - from:
         - namespaceSelector:
             matchLabels:
               release: myrelease
         ports:
           - port: 5555
   ```
   
   The warning is gated on `.Values.flower.extraNetworkPolicies` being set, so 
it
   reaches exactly the users who are mid-migration — and sends them to a key 
Helm
   rejects.
   
   The wrong spelling dates back to #16619, which renamed the parameter to
   `networkPolicy.ingress.from` during review but left the `NOTES.txt` strings 
on
   the earlier `networkPolicy.peers` name. That commit introduced the identical
   bug in the `webserver` notice too; that one disappeared with the Airflow 3
   webserver removal, leaving only flower's.
   
   ### On testing
   
   No test is added.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5)
   
   Generated-by: Claude Code (Opus 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to