This is an automated email from the ASF dual-hosted git repository.
Miretpl pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new f27ddea3561 Add Worker Set override tests for Kerberos sidecar startup
probe (#72017)
f27ddea3561 is described below
commit f27ddea356188ce7edcd9d9799e0269a7be62111
Author: Aaron Chen <[email protected]>
AuthorDate: Wed Aug 26 01:00:34 2026 +0800
Add Worker Set override tests for Kerberos sidecar startup probe (#72017)
The Kerberos sidecar startup probe landed in #71221 without coverage for how
a Worker Set overrides it, so a regression in the per-set merge could ship
unnoticed. Reported in review of #71682.
---
.../helm_tests/airflow_core/test_worker_sets.py | 62 ++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/chart/tests/helm_tests/airflow_core/test_worker_sets.py
b/chart/tests/helm_tests/airflow_core/test_worker_sets.py
index 9892cda4732..040b0919240 100644
--- a/chart/tests/helm_tests/airflow_core/test_worker_sets.py
+++ b/chart/tests/helm_tests/airflow_core/test_worker_sets.py
@@ -1588,6 +1588,68 @@ class TestWorkerSets:
jmespath.search("spec.template.spec.containers[?name=='worker-kerberos'] |
[0]", docs[0]) is None
)
+ @pytest.mark.parametrize(
+ ("startup_probe", "worker_set_startup_probe", "expected"),
+ [
+ (
+ {"enabled": False},
+ {"enabled": True},
+ {
+ "exec": {"command": ["klist", "-s"]},
+ "timeoutSeconds": 5,
+ "initialDelaySeconds": 0,
+ "periodSeconds": 10,
+ "failureThreshold": 6,
+ },
+ ),
+ ({"enabled": True}, {"enabled": False}, None),
+ (
+ {
+ "timeoutSeconds": 1,
+ "initialDelaySeconds": 2,
+ "periodSeconds": 3,
+ "failureThreshold": 4,
+ },
+ {"timeoutSeconds": 11},
+ {
+ "exec": {"command": ["klist", "-s"]},
+ "timeoutSeconds": 11,
+ "initialDelaySeconds": 2,
+ "periodSeconds": 3,
+ "failureThreshold": 4,
+ },
+ ),
+ ],
+ ids=["enabled", "disabled", "custom"],
+ )
+ def test_overwrite_kerberos_sidecar_startup_probe(
+ self, startup_probe, worker_set_startup_probe, expected
+ ):
+ docs = render_chart(
+ values={
+ "workers": {
+ "celery": {
+ "enableDefault": False,
+ "kerberosSidecar": {"enabled": True, "startupProbe":
startup_probe},
+ "sets": [
+ {
+ "name": "test",
+ "kerberosSidecar": {"startupProbe":
worker_set_startup_probe},
+ }
+ ],
+ }
+ }
+ },
+ show_only=["templates/workers/worker-deployment.yaml"],
+ )
+
+ assert (
+ jmespath.search(
+ "spec.template.spec.containers[?name=='worker-kerberos'] |
[0].startupProbe", docs[0]
+ )
+ == expected
+ )
+
@pytest.mark.parametrize(
"values",
[
