karenbraganz commented on PR #65618: URL: https://github.com/apache/airflow/pull/65618#issuecomment-5415127340
> I see the sqlglot dependency was added, what's the reason behind it? (hence failing static check) @dabla check out my dicussion with Ryan [here](https://github.com/apache/airflow/pull/65618#discussion_r3501325615). I am adding a read-only parameter, which ensures that only read queries (not write queries) are allowed when it is set to True. This is to prevent execution of non-idempotent write queries on the triggerer, which could be problematic if the triggerer suddenly shuts down. Such a trigger will not be able to run without any issues on the new triggerer. I am using the sqlglot parser as one of the methods to verify that the query is read-only. This check can be disabled by setting the parameter to False. I explored the option of starting the query on the worker, then deferring to the tirggerer only for polling query completion. I researched this and found that some DB types do not let you start a query on one connection, then poll it on a different connection, so this isn't possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
