ShubhamKapoor992 commented on PR #72025: URL: https://github.com/apache/airflow/pull/72025#issuecomment-5414131312
> Thanks for the fix -- skipping `None`-valued extras in `get_conn()`/`get_uri()` looks correct and avoids emitting `KEY=None` to the Db2 driver. > > I think there have a few things before this is ready to merge: > > 1. The PR title should clearly describe the specific changes rather than just mentioning which provider were modified. > 2. I think we need to add a test to prevent the same issue from happening again in the future. > 3. To keep the branch clean, we should rebase onto main instead of merging. > 4. Similar to the PR title, commit messages should explain the reasoning and the solution behind the changes in detail, so that future contributors touching similar files can quickly understand the context. Thanks for the review. Did the changes you suggested. Could you please review it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
