msumit commented on code in PR #71220:
URL: https://github.com/apache/airflow/pull/71220#discussion_r3860101388
##########
airflow-core/src/airflow/models/pool.py:
##########
@@ -92,6 +92,26 @@ class Pool(Base):
def __repr__(self):
return str(self.pool)
+ @staticmethod
+ def get_include_deferred_override() -> bool | None:
Review Comment:
Again, the control lies with the admin only
I see 3 main approaches here:
1. We let the users provide the value of their choice, store in the DB as
well, but don't honor it if global config is set to True or False. This also
creates an issue of accepting the payload but not honoring it.
2. We don't allow users to pass any value if global config is set (true or
false), but if the admin unsets the global conf, all pools will have a None
value, which is equivalent to false only, again not ideal.
3. We don't allow users to pass any value if global config is set, and set
the value of global config in DB against the pool. When admin changes the conf
to empty, those values will be honored.
The third approach looks better and less confusing than 1 & 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
