ferruzzi commented on code in PR #72060:
URL: https://github.com/apache/airflow/pull/72060#discussion_r3865781087
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_deadlines.py:
##########
@@ -72,6 +76,35 @@ def _cb() -> AsyncCallback:
return AsyncCallback(_CALLBACK_PATH)
Review Comment:
Claude caught this one: These two (`_attach_dag_to_team` and
`_detach_dag_from_team`) are now copied identically three times (here,
`test_dag_run.py:337,354` and `test_task_instances.py:79,96`). At this point,
they should likely be extracted and shared.
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_deadlines.py:
##########
@@ -456,6 +489,54 @@ def test_alert_name_present_when_linked(self, test_client,
session):
unlinked = [dl for dl in deadlines if dl["alert_name"] is None]
assert all(dl["alert_id"] is None for dl in unlinked)
+ @conf_vars({("core", "multi_team"): "True"})
Review Comment:
Do we want a `multi_team: False` run as well, or is that covered elsewhere?
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_deadlines.py:
##########
@@ -456,6 +489,54 @@ def test_alert_name_present_when_linked(self, test_client,
session):
unlinked = [dl for dl in deadlines if dl["alert_name"] is None]
assert all(dl["alert_id"] is None for dl in unlinked)
+ @conf_vars({("core", "multi_team"): "True"})
+ def test_includes_team_name(self, test_client, session):
Review Comment:
(Here and below) Similar tests in `test_dag.py` and `test_team.py` clean up
with `clear_team_name_cache()`, do we need that here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
