TimurRakhmatullin86 commented on PR #69646: URL: https://github.com/apache/airflow/pull/69646#issuecomment-5434247550
Thanks @potiuk — addressed all three: - **Docstring.** Added the retry/duplicate note to `:param raise_on_delivery_failure:`, close to your wording: *"Because the task fails after the batch has already been partially produced, a retry re-produces the whole batch, so messages that were delivered successfully the first time will be produced again."* - **The minor one, taken.** The wrapper now only collects errors when the flag is set (`if err is not None and self.raise_on_delivery_failure`), so nothing is accumulated on the default path. - **Rebased** onto `main` (was ~1093 behind). The only conflicts were in the test file — the imports and the new test block — resolved to keep both your `test_execute_rejects_empty_rendered_topic` and these tests. The rebase also picked up the fix to the pre-existing `:raises AirflowException: _description_` placeholder in the docstring. Force-pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
