Vamsi-klu opened a new pull request, #72130:
URL: https://github.com/apache/airflow/pull/72130

   closes: #55728
   
   The reported stack at `execute_complete` is the trigger error being 
re-raised. On current main the 12.6.1 `sync_to_async(self.get_connection)` hop 
is already gone (`#56791`), but `AzureDataFactoryAsyncHook.get_async_conn` and 
`provide_targeted_factory_async` still read `conn.extra_dejson`. That property 
can call `mask_secret` and do a sync send on the triggerer event loop, which 
raises:
   
   ```
   RuntimeError: You cannot use AsyncToSync in the same thread as an async 
event loop
   ```
   
   Same leftover as `#55179` (MSGraph). Parse extras with 
`json.loads(conn.extra)` on the async path only. Leave the sync hook on 
`extra_dejson` so worker-side masking stays.
   
   Also:
   - `AzureSynapsePipelineAsyncHook.get_async_conn` still called sync 
`get_connection` inside `async def`. Switch it to `get_async_connection` + 
`json.loads`.
   - ADF async `refresh_conn` now closes `_async_conn` (it previously only 
cleared the sync `_conn`).
   
   Tests raise the real AsyncToSync string from `extra_dejson` and still 
succeed. That tripwire failed when I put `extra_dejson` back.
   
   Not changing `execute_complete`.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes
   
   Generated-by: Cursor Grok 4.6 following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to