SEPURI-SAI-KRISHNA commented on PR #72098: URL: https://github.com/apache/airflow/pull/72098#issuecomment-5438037870
Opened #72144 as the tracking issue. One correction to my earlier reply: I said I counted 44 sites passing none of the three. Your 43 is right. I re-derived the audit by parsing every `self.defer(trigger=...)` call with `ast` rather than by grep, and it comes out at exactly your numbers, 110 defer sites, 49 complete, 18 passing only `region_name`, 43 passing none. The sweep also sharpened your second point more than I expected. Of the 61 remaining sites, only 7 can be fixed at the call site, the other 54 have trigger subclasses whose `__init__` never accepts the parameters, so a per-service PR would have to change the trigger signature at every one of them. That makes the `hook_class`-driven default `hook()` on `AwsBaseWaiterTrigger` clearly the right move rather than a nice-to-have, so I'd rather do that next than continue with rds/ecs as I'd planned. Full per-site breakdown by fix shape is in the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
