dost4 commented on code in PR #71950:
URL: https://github.com/apache/airflow/pull/71950#discussion_r3874551316


##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -104,6 +105,30 @@ def _parse_log_level(message: str) -> int:
     return logging.INFO
 
 
+def log_message(

Review Comment:
   no strong opinions here - happy to leave it private.
   Initial thinking is that it's strange to call one of PodManager's private 
methods from KPO. 
   
   But given the context of needing to include it in the provider's public API 
probably sways it in the direction of leaving it private



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to