itzzdev09 commented on PR #72163:
URL: https://github.com/apache/airflow/pull/72163#issuecomment-5445560315
Thanks for the review @SameerMesiah97 — pushed 2e1d575 addressing both
comments, replies inline.
- **Run selection** is now explicit (named booleans + `if`/`else`). I kept
the check covering the "neither given" case too, since dropping it would turn
that input into an `AttributeError` instead of a clean exit — details in the
thread.
- **Help text** now states the selection rule. On the ordering question:
`DagRun` has `UniqueConstraint("dag_id", "logical_date")`, so an exact
logical-date match can only ever return one run — `order_by="-id"` isn't
disambiguating anything. I left the shared `_find_run_id_by_logical_date`
helper alone because `tasks failed-deps` and `tasks states-for-dag-run` use it
too; happy to clean it up as a follow-up.
- **Newsfragment** added as `airflow-core/newsfragments/72163.feature.rst`.
Worth flagging: there's no `airflow-ctl/newsfragments` directory, and
`contributing-docs/18_contribution_workflow.rst` only lists `airflow-core` and
`chart` as destinations. This change is in `airflow-ctl` rather than core, so
let me know if it belongs elsewhere or should be dropped.
On CI — the workflows are still awaiting approval, which I can't trigger
myself as a first-time contributor. Could you kick that off when you get a
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
