ramitkataria opened a new pull request, #72182:
URL: https://github.com/apache/airflow/pull/72182
When Breeze runs with `--forward-credentials`, the host's `~/.ssh` is
bind-mounted read-write at `/root/.ssh` and the container start used to operate
on it directly. Every start overwrote the user's id_rsa with a throwaway key,
appended that key to authorized_keys and three localhost entries to known_hosts
(observed to accumulate hundreds of entries), left a dangling
`authorized_keys2` symlink, and ran `chmod 600 ~/.ssh/*`. That chmod also
strips the execute bit from the `~/.ssh/agent` directory that OpenSSH 10.x uses
for agent sockets. On macOS this kills the launchd-managed ssh-agent and, after
the next reboot, makes every ssh on the host hang waiting on the dead agent
socket.
The ssh-to-localhost setup, which the real-connection SSH and SFTP provider
tests rely on, now lives entirely in `/root/.breeze-ssh`, a path that is never
mounted from the host. sshd accepts the generated key via an `sshd_config.d`
drop-in, the OpenSSH client finds it via an `ssh_config.d` drop-in, and
paramiko-based hooks, which read neither, discover it through an ssh-agent
started by the entrypoint. `entrypoint_exec.sh` exports the agent socket so
`breeze exec` shells get it too. The `authorized_keys2` symlink had no
consumers anywhere in the repo and is dropped.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (Claude Code Fable 5)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
