KidAmnesiac1 opened a new pull request, #72200:
URL: https://github.com/apache/airflow/pull/72200
The scheduler Deployment copies the executor value into a pod label and
sanitises "," and ":" on the way through. Multi-team executor config uses ";"
and "=" as its separators, and neither is legal in a Kubernetes label value, so
a chart configured the documented multi-team way renders a label the API server
rejects and the deploy fails outright.
Why this is worth fixing rather than working around: multi-team executors
are what the edge worker's --team-name flag depends on. EdgeExecutor stamps
each edge_job row with its executor's team, and a worker started with
--team-name only picks up jobs whose team matches. Without a per-team executor
entry the jobs get stamped NULL, the worker sits there reporting it has no
work, and the tasks stay queued.
There isn't a good way around it from values.yaml. Quoting doesn't help,
because the restriction is on the characters in the label rather than on the
YAML. Setting config.core.executor instead is refused by the check in
NOTES.txt. Overriding the label through .Values.labels does render, but it
stamps the label on every object in the chart and breaks the migrations Job,
whose pod template can't be changed in place.
Sanitising ";" and "=" alongside the separators the chart already handles
keeps the label legal while airflow.cfg still gets the real value.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ X] Yes Claude Opus 5
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
