hizyyo commented on issue #70676: URL: https://github.com/apache/airflow/issues/70676#issuecomment-5454750204
Hi! I would like to submit a clean fix for this ReDoS issue in `SparkSubmitHook._mask_cmd()`. I propose to: 1. Add a fast substring check for sensitive keywords prior to invoking the regex. 2. Refactor the regex pattern to eliminate catastrophic backtracking while preserving the ability to mask quoted secrets with spaces. 3. Add regression tests with long payload strings to verify linear O(n) execution time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
