olmaks opened a new pull request, #72253:
URL: https://github.com/apache/airflow/pull/72253
`__register_plugins` in `task-sdk/src/airflow/sdk/plugins_manager.py` uses
`return` where it means
`continue`:
```python
if plugin_instance.name in loaded_plugins:
return
```
The first duplicate plugin name therefore abandons the rest of the batch,
and every plugin after it is
dropped — silently, since nothing is logged and `_get_plugins()` still
returns an empty `import_errors`.
`airflow-core` carries a copy of this function and fixed it in #60498, then
hardened it in #66649 (record
the duplicate in `import_errors`). Neither fix reached the Task SDK copy.
This PR applies both, so the
block becomes byte-identical to the core one.
It matters because the Task SDK copy is the one the task-running process
uses. While the two disagree,
plugins load for the scheduler and API server but go missing inside tasks —
most sharply, a plugin
registering `on_task_instance_running` / `on_task_instance_failed` after a
duplicate name never fires,
with no error anywhere to attribute it to. Duplicate names are not exotic:
the same plugin shipped both
flattened and as a package, or present in the plugins folder and as an entry
point, is enough.
Covered by a new `task-sdk/tests/task_sdk/test_plugins_manager.py` carrying
the two cases the core suite
already has for this branch; both fail on `main` and pass with the change.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes
Generated-by: Claude Code following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
