RehanAhmad25 commented on PR #69925: URL: https://github.com/apache/airflow/pull/69925#issuecomment-5463997864
@Vamsi-klu I went through your PR pretty thoroughly and didn’t find any major issues that I felt needed to be flagged. Since your PR already explores the lazy-resolution approach, opening another PR from my side would essentially duplicate the same direction of work and could make it harder for the maintainers to review and decide between overlapping PRs. That’s why I didn’t open a separate lazy-resolution PR. Regarding @uranusjr’s earlier review, my understanding was that the preference was to try fixing the underlying `start_from_trigger` issue first, rather than deciding to remove the feature outright. Since it’s still not completely settled whether the feature can/should be retained, I’ve kept my PR open for now. If #69746 ends up being the preferred approach and the feature is retained, I’m absolutely fine with my PR being superseded and closed. I just didn’t want to prematurely close it while the direction is still being worked out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
