Vamsi-klu commented on PR #69746: URL: https://github.com/apache/airflow/pull/69746#issuecomment-5463684923
@uranusjr Following up on the Aug 11 request to decide on https://github.com/apache/airflow/issues/69543 first. Comparison is now on the issue. Short version: this PR keeps start_from_trigger with a lazy TimeOfDayTrigger (parse-stable target_time + tz, moment resolved at trigger start). #69925 deprecates/ignores the flag. You wrote on the issue on Aug 17 that dropping it looks suboptimal and that we should try to fix the feature first; this branch is that fix, matching what @potiuk asked for before he dismissed his review today. Please take another look at the current head (92fee51) and dismiss the Aug 11 CHANGES_REQUESTED if you are still happy with keep-and-fix. Static checks on the latest run still failed (https://github.com/apache/airflow/actions/runs/32676309808/job/99109390185). The log is update-breeze-cmd-output rewriting breeze CLI screenshot hashes after merge, not ruff/mypy/bandit on the sensor. I am not stuffing a breeze-docs regen into this PR unless a maintainer wants that. --- Drafted-by: Cursor Grok 4.6; reviewed by @Vamsi-klu before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
