moomindani commented on code in PR #72148:
URL: https://github.com/apache/airflow/pull/72148#discussion_r3887844298
##########
providers/databricks/src/airflow/providers/databricks/operators/databricks.py:
##########
@@ -452,6 +452,13 @@ class DatabricksCreateJobsOperator(BaseOperator):
.. seealso::
This will only be used on create. In order to reset ACL consider
using the Databricks
UI.
+ :param performance_target: Optional performance mode for runs of this job
on serverless compute.
+ Either ``PERFORMANCE_OPTIMIZED`` (prioritizes fast startup and
execution) or
+ ``STANDARD`` (enables cost-efficient execution of serverless
workloads). This field
+ will be templated.
+
+ .. seealso::
+ https://docs.databricks.com/api/workspace/jobs/create
Review Comment:
Worth one more sentence here: an unrecognised value is accepted and then
ignored, so a typo fails silently rather than loudly.
Measured against a live workspace: `jobs/create` with `performance_target:
"FAST"` returns 200, and `jobs/get` afterwards shows no `performance_target` in
the job settings at all — the value is dropped. On the `run-now` side the same
string is accepted and the run's `effective_performance_target` falls back to
the job-level value.
Not a request for validation — that question was settled on #71374 and the
reasoning there (existing workloads pass unrecognised values and run on the
default) matches what I see. Just something a user would rather read in the
operator docs than discover from a billing line, e.g. "Values other than these
two are ignored by the API rather than rejected."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
