aaron-y-chen opened a new pull request, #72293: URL: https://github.com/apache/airflow/pull/72293
related: #72248 `test_patched_helpers_return_the_mock_substitutes` fails on Python 3.11 and newer, which turned the canary build red on `main`. https://github.com/apache/airflow/actions/runs/33299458686 `_get_hooks_with_mocked_fab` puts a separate `MagicMock` into `sys.modules` for every mocked name, so `sys.modules["wtforms.validators"]` and the `validators` attribute of the `wtforms` mock are two different objects. `mock.patch` only ever lands on one of them, and which one changed in Python 3.11, when `unittest.mock._get_target` moved from attribute lookup to `pkgutil.resolve_name`. The test read the object that only carries the substitute up to 3.10. Pull requests run the core test jobs on the default Python (3.10) only, so this was invisible until the canary matrix exercised 3.11-3.14. The test now reads both objects and asserts the substitute is on exactly one of them, which holds on every supported version. --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) Generated-by: [Claude Opus 5] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
