dkranchii commented on PR #68403: URL: https://github.com/apache/airflow/pull/68403#issuecomment-5472643036
Thanks for the context, @o-nikolas - that matches the server-side design: the Execution API is the authoritative source for `team_name` (resolved via `TaskInstance → DagModel → DagBundleModel → Team` and delivered as part of `TIRunContext`), and it's already consumed by triggers, XCom, and `AIRFLOW_CTX_TEAM_NAME`. Nothing changes at runtime with this PR - the field is already on `TIRunContext.dag_run` and already reaches user code; `DagRunProtocol` just hadn't been synced with the shipped schema, so `context["dag_run"].team_name` gets flagged `[attr-defined]` by type checkers today. @ashb - with @o-nikolas (who added the server-side plumbing in #65617) confirming the design intent and that a worker-side flag wouldn't be authoritative anyway (Celery/Edge only stamp the worker parent, not the `airflow tasks run` subprocess), would you be OK dismissing the change-request on this typing-only sync? Happy to file a follow-up issue if you'd like to revisit the server-side placement (e.g. promoting `team_name` off `DagRun` onto `DagResponse` / `DagResult`) - that's an architectural discussion separate from keeping `DagRunProtocol` aligned with what the server already ships. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
