LostSnowfluff opened a new pull request, #72486:
URL: https://github.com/apache/airflow/pull/72486
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Description
The Connections bulk update action accepts `update_mask` and documents that
only
the listed fields are applied. However,
`BulkConnectionService.handle_bulk_update`
does not pass `action.update_mask` to `update_orm_from_pydantic`.
As a result, fields included in the request body but omitted from the update
mask
are still updated. For example, a request with `update_mask=["description"]`
also
changes `conn_type` when `conn_type` is present in the entity. This makes
bulk
updates inconsistent with the single-connection PATCH behavior and can modify
fields that the caller did not intend to change.
Pass `action.update_mask` to the existing ORM update helper so bulk updates
apply
the same field filtering as other update paths. Add a regression test
covering a
request that provides both `conn_type` and `description` while masking only
`description`.
No documentation changes are needed because this restores the behavior
already
described by the existing `update_mask` contract.
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (OpenAI Codex)
Generated-by: OpenAI Codex following the guidelines at
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
