fabbuc-gyg commented on PR #70385: URL: https://github.com/apache/airflow/pull/70385#issuecomment-5540277910
Thanks @moomindani for the thorough verification, and sorry for the slow turnaround @eladkal. Both open items are addressed, and the branch is rebased on current `main`: - **D200 (blocker):** docstring is now a single line. Verified with the pinned `ruff==0.16.4` from `.pre-commit-config.yaml` — `ruff check` and `ruff format --check` both pass on the two touched files. `prek` is installed locally now. - **Annotation:** `error: str | int -> str | int` is now `error: Any -> Any`. You were right that `str | int` implied `int` was meaningful when it was only incidental; the guard is there to be defensive about whatever Databricks returns in `run_output["error"]`, and `Any` says that honestly. Behaviour is unchanged, so the existing tests (including the non-string passthrough case) still cover it. No changes to the sanitizer logic or its scoping — appreciated the confirmation that `run_state.state_message` is already safe via `RunState.to_json()` and that the character class is not over-broad. CI on the new commit is sitting in `action_required`, so it needs a committer to approve the run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
