FrankYang0529 commented on code in PR #72550:
URL: https://github.com/apache/airflow/pull/72550#discussion_r3943360471
##########
dev/breeze/src/airflow_breeze/global_constants.py:
##########
@@ -874,22 +874,25 @@ def get_airflow_extras():
"remove-providers": "anthropic common.messaging common.dataquality
edge3 fab git keycloak informatica common.ai opensearch",
"run-unit-tests": "true",
},
+ # common.ai supports Airflow >= 3.0, but the constraint files these jobs
install with pin
+ # pydantic, opentelemetry-api or pydantic-ai-slim itself below its
pydantic-ai-slim>=2.0.0
+ # floor - the provider ends up mismatched and its tests fail on import, so
skip it there.
{
"python-version": "3.10",
"airflow-version": "3.0.6",
- "remove-providers": "",
+ "remove-providers": "common.ai",
Review Comment:
IIUC, adding `common.ai` to `remove-providers` means these three jobs stop
running the provider entirely, not just the failing MCP tests. The workflow
deletes the wheel before installing and passes the same list as
`--skip-providers`, which breeze turns into
`--ignore=providers/common/ai/tests`.
https://github.com/apache/airflow/blob/20563781c3d9c059985e1f9b741f9414e21bd8f8/.github/workflows/test-providers.yml#L226-L234
https://github.com/apache/airflow/blob/20563781c3d9c059985e1f9b741f9414e21bd8f8/.github/workflows/test-providers.yml#L274
https://github.com/apache/airflow/blob/20563781c3d9c059985e1f9b741f9414e21bd8f8/dev/breeze/src/airflow_breeze/commands/testing_commands.py#L1960-L1967
#72581 pin devel dependencies to uv.lock, so it doesn't need to skip
`common.ai` provider. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
