sivavarma-x commented on code in PR #69761:
URL: https://github.com/apache/airflow/pull/69761#discussion_r3944628843
##########
airflow-core/tests/unit/plugins/test_plugins_manager.py:
##########
@@ -241,8 +244,14 @@ def
test_should_warning_about_external_views_or_react_app_wrong_object(self, cap
class TestPluginA(AirflowPlugin):
name = "test_plugin_a"
- external_views = [[{"nested_list": "/test_route"}], {"url_route":
"/test_route"}]
- react_apps = [[{"nested_list": "/test_route"}], {"url_route":
"/test_route_react_app"}]
+ external_views = [
+ [{"nested_list": "/test_route"}],
+ {"name": "A-view", "href": "/a", "url_route": "/test_route"},
+ ]
+ react_apps = [
+ [{"nested_list": "/test_route"}],
+ {"name": "A-react", "bundle_url": "/a.js", "url_route":
"/test_route_react_app"},
+ ]
Review Comment:
Sure — restored the original tests with narrow `# type:
ignore[typeddict-item, ...]` on the partial-dict assignments to satisfy `mypy`
while preserving the original coverage, and added a new
`test_loads_typed_external_views_and_react_apps` that exercises the same code
path with fully-typed entries and no ignores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
