justinpakzad commented on code in PR #70771: URL: https://github.com/apache/airflow/pull/70771#discussion_r3950314806
########## airflow-ctl/src/airflowctl/ctl/help_texts.yaml: ########## @@ -28,6 +28,11 @@ assets: delete-queued-events: "Delete all queued events for a given asset" delete-dag-queued-events: "Delete all queued asset events for a given Dag" delete-queued-event: "Delete a specific queued asset event for a given Dag and asset" + list-state-store: "List all state store entries for an asset" + get-state-store: "Retrieve a single asset state store entry by its ID and key" + set-state-store: "Set an asset state store value. Parsed as JSON if valid, otherwise stored as a string" Review Comment: Fair point, I had a look and the server also rejects NaN/Infinity as well as oversized values (larger than `max_value_storage_bytes`). I'm not sure it's necessary to call them out in the help texts since the client-side parsing does in fact parse those successfully, it's the server that ends up rejecting them (as you mentioned) and it surfaces a clear error message. That said, happy to add a note if you feel strongly about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
